Fix: getAttemptsTaken returns incorrect counts following a language change
#75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a language change (fixes #74).
Contributor
Author
|
Attempted to use the following instead to make it more obvious that the plugin was being re-initialised when changing language, but this seemingly caused issues with other plugins not returning to the correct state: onLanguageChange(newLanguage, previousLanguage) {
if (!previousLanguage) return;
this.stopListening();
this.initialize();
} |
oliverfoster
approved these changes
Jan 8, 2026
ethan-lp
approved these changes
Jan 8, 2026
github-project-automation
bot
moved this from Needs Reviewing
to Recently Released
in adapt_framework: The TODO Board
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74.
Fix
getAttemptsTakenreturns incorrect counts following a language change. Remove existing listeners before they are added again following a language change.